Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N°7963 - Inlineimage::SetDefaultOrgId blend field name between Person and linked class #680

Open
wants to merge 8 commits into
base: support/3.2
Choose a base branch
from
Open

N°7963 - Inlineimage::SetDefaultOrgId blend field name between Person and linked class #680

wants to merge 8 commits into from

Conversation

accognet
Copy link
Contributor

@accognet accognet commented Nov 13, 2024 •
edited
Loading

Internal
Allow to use DBObject::MapContextParam without bug

@CombodoApplicationsAccount CombodoApplicationsAccount added the internal Work made by Combodo label Nov 13, 2024
@accognet accognet added the bug Something isn't working label Nov 13, 2024
@accognet accognet self-assigned this Nov 13, 2024
@rquetiez rquetiez self-requested a review November 25, 2024 14:02
rquetiez
rquetiez requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@rquetiez rquetiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though the fix is ok, the bug shows that a refactoring would be appreciated. See UserRightsProfiles::GetOwnerOrganizationAttCode.

@accognet
Refactor
83f1476 
+ use new function in Attachment
@accognet
Replace UserRightsProfile::GetOwnerOrganizationAttCode($sClass) by Us…
309b6bd 
…erRights::GetOwnerOrganizationAttCode($sClass)
@accognet
indentation
f26ed0e
@rquetiez
Copy link
Contributor

Code review:

  • Ok for the refactoring
  • Code formatting (opening brackets) to be adjusted
  • Tests auto should be added both on UserRights::GetOwnerOrgAttCode and on InlineImage::SetDefaultOrgId

@rquetiez
Copy link
Contributor

Code review:
Ok, but Attachment::SetDefaultOrgId should be tested too.

@rquetiez rquetiez requested a review from v-dumas December 16, 2024 14:55
@rquetiez
Copy link
Contributor

I've added Vincent to the reviewers so that he will check the unit tests

rquetiez
rquetiez approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@rquetiez rquetiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the implementation, leaving the tests coverage review to @v-dumas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rquetiez rquetiez rquetiez approved these changes

@v-dumas v-dumas Awaiting requested review from v-dumas

Assignees

@accognet accognet

Labels
bug Something isn't working internal Work made by Combodo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@accognet @rquetiez @CombodoApplicationsAccount